Query no matches on .kibana instead of .kibana-devnull #7286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The devnull query was always a big hack to try to force Elasticsearch into giving us an empty search response when we know there are no indices that match the current search in the current timeframe. That hack does not work in all situations, for example if someone creates an index called .kibana-devnull or doesn't enable access to that index pattern in shield. We know users must have access to the kibana index, so it should be safe to query it, and we know we can force an empty response by doing a must_not match_all boolean query, so that's what we do here. Performance shouldn't be an issue since the kibana index is just storing kibana meta data, configurations, and saved objects.
|
LGTM |
|
@tsullivan You mentioned that you removed the |
The utility that calls fieldStats returns back an array. Previously it did |
|
Ah, I see. |
|
Seems like this should work a-ok |
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Query no matches on .kibana instead of .kibana-devnull Former-commit-id: a9abb0e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The devnull query was always a big hack to try to force Elasticsearch
into giving us an empty search response when we know there are no
indices that match the current search in the current timeframe. That
hack does not work in all situations, for example if someone creates an
index called .kibana-devnull or doesn't enable access to that index
pattern in shield.
We know users must have access to the kibana index, so it should be safe
to query it, and we know we can force an empty response by doing a
must_not match_all boolean query, so that's what we do here.
Performance shouldn't be an issue since the kibana index is just storing
kibana meta data, configurations, and saved objects.